Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1201333002: add more tests (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -19 lines) Patch
M gm/offsetimagefilter.cpp View 2 chunks +41 lines, -19 lines 3 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201333002/20001
5 years, 6 months ago (2015-06-23 21:29:14 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/5fbb623099a6d0e0e72e7e230e75014fd64ae240
5 years, 6 months ago (2015-06-23 21:35:02 UTC) #3
reed1
This latest rev. addes explicit combos of clipping and croprects for offsetimagefilter. The last combo ...
5 years, 6 months ago (2015-06-23 21:37:40 UTC) #5
robertphillips
5 years, 6 months ago (2015-06-24 16:23:53 UTC) #6
Message was sent while issue was closed.
lgtm + dox requests

https://codereview.chromium.org/1201333002/diff/20001/gm/offsetimagefilter.cpp
File gm/offsetimagefilter.cpp (right):

https://codereview.chromium.org/1201333002/diff/20001/gm/offsetimagefilter.cp...
gm/offsetimagefilter.cpp:166: canvas->save();
// 0,0: rect draw - no offset
?

https://codereview.chromium.org/1201333002/diff/20001/gm/offsetimagefilter.cp...
gm/offsetimagefilter.cpp:168: 
// 1,0: offset rect draw
?

https://codereview.chromium.org/1201333002/diff/20001/gm/offsetimagefilter.cp...
gm/offsetimagefilter.cpp:171: 
// 2,0: offset rect draw with crop rect - 3/4 of the rect should be cropped
etc ?

Powered by Google App Engine
This is Rietveld 408576698