Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: Source/core/events/MouseEvent.idl

Issue 1201193005: Move UIEvent.pageX/pageY/layerX/layerY to MouseEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/MouseEvent.idl
diff --git a/Source/core/events/MouseEvent.idl b/Source/core/events/MouseEvent.idl
index 21c0a2fd5059112c134a1d412a885c598ed4e266..095181695091bbe3593fc38a776b035307af7ec8 100644
--- a/Source/core/events/MouseEvent.idl
+++ b/Source/core/events/MouseEvent.idl
@@ -25,6 +25,8 @@
] interface MouseEvent : UIEvent {
readonly attribute long screenX;
readonly attribute long screenY;
+ readonly attribute long pageX;
Rick Byers 2015/06/23 19:33:00 nit: Philip has been trying to align the interface
dtapuska 2015/06/23 19:36:39 I was trying to keep the idl matching the spec (fo
Rick Byers 2015/06/23 19:44:46 The official home of this event definition is http
philipj_slow 2015/07/01 14:17:46 I made a mistake when cleaning up this file, I mis
dtapuska 2015/07/02 17:32:35 Done.
+ readonly attribute long pageY;
readonly attribute long clientX;
readonly attribute long clientY;
readonly attribute boolean ctrlKey;
@@ -69,6 +71,8 @@
[MeasureAs=MouseEventWhich] readonly attribute long which;
[DeprecateAs=PrefixedMouseEventMovementX, ImplementedAs=movementX] readonly attribute long webkitMovementX;
[DeprecateAs=PrefixedMouseEventMovementY, ImplementedAs=movementY] readonly attribute long webkitMovementY;
+ [MeasureAs=MouseEventLayerX] readonly attribute long layerX;
philipj_slow 2015/07/01 14:17:46 I would suggest just using [Measure] and using the
dtapuska 2015/07/02 17:32:35 Done.
+ [MeasureAs=MouseEventLayerY] readonly attribute long layerY;
// FIXME: dataTransfer belongs on the DragEvent interface. crbug.com/498504
readonly attribute DataTransfer dataTransfer;

Powered by Google App Engine
This is Rietveld 408576698