Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(189)

Issue 1201193004: Mandoline: Fixed assert on startup (Closed)

Created:
4 years, 10 months ago by Fady Samuel
Modified:
4 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium), ssid
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mandoline: Fixed assert on startup HTMLViewer does not yet support memory infra plumbing, so I've removed an assert. BUG=none TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/platform/heap/BlinkGCMemoryDumpProvider.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Fady Samuel
4 years, 10 months ago (2015-06-23 15:42:04 UTC) #2
Primiano Tucci (use gerrit)
LGTM +ssid: let's keep in mind that there are other embedders of blink where we ...
4 years, 10 months ago (2015-06-23 15:50:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201193004/1
4 years, 10 months ago (2015-06-23 16:07:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/36147)
4 years, 10 months ago (2015-06-23 16:14:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201193004/1
4 years, 10 months ago (2015-06-23 16:17:58 UTC) #9
Primiano Tucci (use gerrit)
You need an OWNER lgtm here. presubmit is failing. ticking again is not going to ...
4 years, 10 months ago (2015-06-23 16:32:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197665
4 years, 10 months ago (2015-06-23 17:11:12 UTC) #12
haraken
4 years, 10 months ago (2015-06-23 23:07:21 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698