Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1201193003: [ic] Record call counts for monomorphic calls made with an IC. (Closed)

Created:
5 years, 6 months ago by mvstanton
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Record call counts for monomorphic calls made with an IC. The idea is that TurboFan can use this information for more intelligent inlining. R=bmeurer@chromium.org Committed: https://crrev.com/c1a4f7477f03ebb0c6889bbf8ea6a4c928e0d413 Cr-Commit-Position: refs/heads/master@{#29281}

Patch Set 1 #

Patch Set 2 : ARM and x64 ports. #

Patch Set 3 : Adjustment, plus test. #

Patch Set 4 : Good opportunity for minor cleanup. #

Patch Set 5 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -35 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 3 chunks +19 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 3 chunks +25 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 3 chunks +15 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 3 chunks +20 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 3 chunks +20 lines, -0 lines 0 comments Download
M src/type-feedback-vector.h View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M src/type-feedback-vector.cc View 1 2 3 6 chunks +43 lines, -22 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 3 chunks +15 lines, -0 lines 0 comments Download
A test/mjsunit/call-counts.js View 1 2 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mvstanton
Hi Benedikt, here is the change we discussed. I'm running some perf jobs and will ...
5 years, 6 months ago (2015-06-24 09:41:36 UTC) #2
Benedikt Meurer
Looks good to me. Thanks for doing that.
5 years, 6 months ago (2015-06-24 11:21:20 UTC) #3
mvstanton
Okay, now the counts are incremented by 2 in order to leave a bit free ...
5 years, 6 months ago (2015-06-24 13:28:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201193003/40001
5 years, 6 months ago (2015-06-24 14:22:54 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-24 14:22:56 UTC) #8
Benedikt Meurer
Awesome. LGTM!
5 years, 6 months ago (2015-06-25 08:16:47 UTC) #9
mvstanton
Committed patchset #5 (id:80001) manually as c1a4f7477f03ebb0c6889bbf8ea6a4c928e0d413 (presubmit successful).
5 years, 6 months ago (2015-06-25 08:44:04 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 08:44:09 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c1a4f7477f03ebb0c6889bbf8ea6a4c928e0d413
Cr-Commit-Position: refs/heads/master@{#29281}

Powered by Google App Engine
This is Rietveld 408576698