build/config/features.gni - Issue 1201163002: Remove hotword installation code at compile time if hotwording disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/features.gni

Issue 1201163002: Remove hotword installation code at compile time if hotwording disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Same fix for GN builds. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/features.gni

diff --git a/build/config/features.gni b/build/config/features.gni

index f362777e92eb6974350f7e1881b4cc824303fb96..3e2bb2e07cfe521c82e48eafc830fa27f5609cc8 100644

--- a/build/config/features.gni

+++ b/build/config/features.gni

@@ -53,6 +53,11 @@ declare_args() {

# Enables the Media Router.

enable_media_router = !is_ios && !is_android

+ # 'Ok Google' hotwording is disabled by default in open source builds. Set to

+ # true to enable. (This will download a closed-source NaCl module at startup.)

+ # Chrome-branded builds have this enabled by default.

+ enable_hotwording = is_chrome_branded

# Enables proprietary codecs and demuxers; e.g. H264, MOV, AAC, and MP3.

# Android OS includes support for proprietary codecs regardless of building

# Chromium or Google Chrome. We also ship Google Chrome and Chromecast with

« build/config/BUILD.gn ('K') | « build/config/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »