Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: chrome/browser/search/hotword_service_unittest.cc

Issue 1201163002: Remove hotword installation code at compile time if hotwording disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/hotword_service_unittest.cc
diff --git a/chrome/browser/search/hotword_service_unittest.cc b/chrome/browser/search/hotword_service_unittest.cc
index 315c85ae0545e8803163d7ddb8d7c04b5689c5e6..16d513adfc19a75ee0ca334c9e916b21af014bf0 100644
--- a/chrome/browser/search/hotword_service_unittest.cc
+++ b/chrome/browser/search/hotword_service_unittest.cc
@@ -163,8 +163,7 @@ INSTANTIATE_TEST_CASE_P(HotwordServiceTests,
::testing::Values(
extension_misc::kHotwordSharedModuleId));
-// Disabled due to http://crbug.com/503963.
-TEST_P(HotwordServiceTest, DISABLED_IsHotwordAllowedLocale) {
+TEST_P(HotwordServiceTest, IsHotwordAllowedLocale) {
TestingProfile::Builder profile_builder;
scoped_ptr<TestingProfile> profile = profile_builder.Build();
@@ -306,8 +305,7 @@ TEST_P(HotwordServiceTest, UninstallReinstallTriggeredCorrectly) {
#if defined(ENABLE_HOTWORDING)
EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile()));
#else
- // Disabled due to http://crbug.com/503963.
- // EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile()));
+ EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile()));
#endif
// Different but valid locale so expect uninstall.
@@ -337,8 +335,7 @@ TEST_P(HotwordServiceTest, UninstallReinstallTriggeredCorrectly) {
#if defined(ENABLE_HOTWORDING)
EXPECT_TRUE(HotwordServiceFactory::IsHotwordAllowed(profile()));
#else
- // Disabled due to http://crbug.com/503963.
- // EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile()));
+ EXPECT_FALSE(HotwordServiceFactory::IsHotwordAllowed(profile()));
#endif
EXPECT_FALSE(hotword_service->MaybeReinstallHotwordExtension());
EXPECT_EQ(1, hotword_service->uninstall_count()); // no change
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698