Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(61)

Issue 1201153002: Introduce composed tree version of canonicalPosition() in VisiblePosition (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent, hajimehoshi
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of canonicalPosition() in VisiblePosition This patch introduces composed tree version of |canonicalPosition()| along with composed tree version of functions called from |canonicalPosition()| for a preparation of making |VisiblePostion| to work with composed tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=webkit_unit_tests --gtest_filter=VisiblePosition* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197649

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
M Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
A Source/core/editing/VisiblePositionTest.cpp View 1 chunk +89 lines, -0 lines 1 comment Download
M Source/core/editing/htmlediting.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-23 07:46:48 UTC) #2
tkent
lgtm https://codereview.chromium.org/1201153002/diff/1/Source/core/editing/VisiblePositionTest.cpp File Source/core/editing/VisiblePositionTest.cpp (right): https://codereview.chromium.org/1201153002/diff/1/Source/core/editing/VisiblePositionTest.cpp#newcode52 Source/core/editing/VisiblePositionTest.cpp:52: PassRefPtrWillBeRawPtr<ShadowRoot> VisiblePositionTest::createShadowRootForElementWithIDAndSetInnerHTML(TreeScope& scope, const char* hostElementID, const char* ...
4 years, 10 months ago (2015-06-23 07:56:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201153002/1
4 years, 10 months ago (2015-06-23 07:56:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67838)
4 years, 10 months ago (2015-06-23 10:22:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201153002/1
4 years, 10 months ago (2015-06-23 10:30:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67858)
4 years, 10 months ago (2015-06-23 12:56:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201153002/1
4 years, 10 months ago (2015-06-23 13:23:00 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 14:22:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197649

Powered by Google App Engine
This is Rietveld 408576698