Removing broken ideograph font variant

Removing broken ideograph font variant

The broken ideograph variant was a special case used in
SimpleFontDataMac.mm for returning horizontal advances for a glyph while
in vertical writing modes. This special case functionality was removed
in efe32dde1dc when we switched to HarfBuzz on Mac.

Vertical text is going through the complex text path now, which should
handle the level of vertical support that an individual font has.

BUG=501623
R=kojii, eae

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197836

[drott, 2015-06-25 07:46:30]

Patchset #3 (id:40001) has been deleted

[drott, 2015-06-25 08:11:24]

drott@chromium.org changed reviewers:
+ eae@chromium.org, kojii@chromium.org

[drott, 2015-06-25 10:47:56]

I think this is ready for review now. The rebaselines look like progressions to
me, the emphasis marks better match the size of their icon counterparts,
probably a result of not losing font size information when replacing
FontPlatformData for emphasis mark drawing with a BrokenIdeograph variant.
https://blink.gs/results/1201143002 (patch set 60001).

[kojii, 2015-06-25 15:35:27]

Without knowing what BrokenIdeograph is for, I agree that rebaselines look like
progressions. I tried a few samples but do not see any obvious changes, and code
changes look good to me. I was actually surprised, from the diff, this does
almost nothing. Maybe just an old experimental code, or maybe "don't do anything
special" is the intention.

One thing not sure is that, almost every Japanese font has vertical glyphs, so I
suspect this was for Chinese, and I can't test Chinese very much. But as far as
I understand, Chinese fonts also evolved rapidly in these a few years, so I'm
positive to take this direction.

[eae, 2015-06-25 16:05:11]

LGTM

Ship it!

[drott, 2015-06-25 16:38:42]

Thanks for your reviews.

[drott, 2015-06-25 16:38:46]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2015-06-25 16:39:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1201143002/80001

[commit-bot: I haz the power, 2015-06-25 17:36:45]

Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197836