Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(140)

Issue 1201143002: Removing broken ideograph font variant (Closed)

Created:
4 years, 10 months ago by drott
Modified:
4 years, 10 months ago
Reviewers:
kojii, eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing broken ideograph font variant The broken ideograph variant was a special case used in SimpleFontDataMac.mm for returning horizontal advances for a glyph while in vertical writing modes. This special case functionality was removed in efe32dde1dc when we switched to HarfBuzz on Mac. Vertical text is going through the complex text path now, which should handle the level of vertical support that an individual font has. BUG=501623 R=kojii, eae Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197836

Patch Set 1 #

Patch Set 2 : remove brokenideograph #

Patch Set 3 : Rebased #

Patch Set 4 : Updating TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -35 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/fonts/Font.cpp View 1 2 2 chunks +3 lines, -14 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 5 chunks +1 line, -6 lines 0 comments Download
M Source/platform/fonts/SimpleFontData.cpp View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
drott
I think this is ready for review now. The rebaselines look like progressions to me, ...
4 years, 10 months ago (2015-06-25 10:47:56 UTC) #3
kojii
Without knowing what BrokenIdeograph is for, I agree that rebaselines look like progressions. I tried ...
4 years, 10 months ago (2015-06-25 15:35:27 UTC) #4
eae
LGTM Ship it!
4 years, 10 months ago (2015-06-25 16:05:11 UTC) #5
drott
Thanks for your reviews.
4 years, 10 months ago (2015-06-25 16:38:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201143002/80001
4 years, 10 months ago (2015-06-25 16:39:25 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 17:36:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197836

Powered by Google App Engine
This is Rietveld 408576698