extensions/browser/api/networking_config/networking_config_service.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert test JS change Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/management/management_api.cc ('k') | extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc » ('j') | extensions/browser/extension_event_histogram_value.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service.cc

diff --git a/extensions/browser/api/networking_config/networking_config_service.cc b/extensions/browser/api/networking_config/networking_config_service.cc

index b10813dcc41638107c59a5b6c606eb05e6db0ffc..c35fd7eaa56a6f81f90b70a8afebe14c456fbfaf 100644

--- a/extensions/browser/api/networking_config/networking_config_service.cc

+++ b/extensions/browser/api/networking_config/networking_config_service.cc

@@ -197,7 +197,8 @@ scoped_ptr<Event> NetworkingConfigService::CreatePortalDetectedEventAndDispatch(

scoped_ptr<base::ListValue> results =

extensions::core_api::networking_config::OnCaptivePortalDetected::Create(

network_info);

- scoped_ptr<Event> event(new Event(extensions::core_api::networking_config::

+ scoped_ptr<Event> event(new Event(events::UNKNOWN,

+ extensions::core_api::networking_config::

OnCaptivePortalDetected::kEventName,

results.Pass()));

return event.Pass();