extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_config/networking_config_service.cc ('k') | extensions/browser/api/networking_private/networking_private_event_router_nonchromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc

diff --git a/extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc b/extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc

index aa5df44011d3190f19bd4e5b940ddcbfedaefd20..9ecbd9cd9472236751bb2c0f9de3ce770136d12c 100644

--- a/extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc

+++ b/extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc

@@ -170,7 +170,8 @@ void NetworkingPrivateEventRouterImpl::NetworkListChanged() {

scoped_ptr<base::ListValue> args(

core_api::networking_private::OnNetworkListChanged::Create(changes));

scoped_ptr<Event> extension_event(

- new Event(core_api::networking_private::OnNetworkListChanged::kEventName,

+ new Event(events::UNKNOWN,

+ core_api::networking_private::OnNetworkListChanged::kEventName,

args.Pass()));

event_router->BroadcastEvent(extension_event.Pass());

}

@@ -185,6 +186,7 @@ void NetworkingPrivateEventRouterImpl::DeviceListChanged() {

scoped_ptr<base::ListValue> args(

core_api::networking_private::OnDeviceStateListChanged::Create());

scoped_ptr<Event> extension_event(new Event(

+ events::UNKNOWN,

core_api::networking_private::OnDeviceStateListChanged::kEventName,

args.Pass()));

event_router->BroadcastEvent(extension_event.Pass());

@@ -204,7 +206,8 @@ void NetworkingPrivateEventRouterImpl::NetworkPropertiesUpdated(

core_api::networking_private::OnNetworksChanged::Create(

std::vector<std::string>(1, network->guid())));

scoped_ptr<Event> extension_event(

- new Event(core_api::networking_private::OnNetworksChanged::kEventName,

+ new Event(events::UNKNOWN,

+ core_api::networking_private::OnNetworksChanged::kEventName,

args.Pass()));

event_router->BroadcastEvent(extension_event.Pass());

}

@@ -267,6 +270,7 @@ void NetworkingPrivateEventRouterImpl::OnPortalDetectionCompleted(

core_api::networking_private::OnPortalDetectionCompleted::Create(path,

status));

scoped_ptr<Event> extension_event(new Event(

+ events::UNKNOWN,

core_api::networking_private::OnPortalDetectionCompleted::kEventName,

args.Pass()));

event_router->BroadcastEvent(extension_event.Pass());