extensions/browser/api/cast_channel/cast_channel_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc ('k') | extensions/browser/api/hid/hid_device_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_channel_api.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_api.cc b/extensions/browser/api/cast_channel/cast_channel_api.cc

index c3c2e5ecd95b0b6649cd174da6451b3aac6b90c2..bc7d12fa35bb6d0a30653a529205aba1202a34be 100644

--- a/extensions/browser/api/cast_channel/cast_channel_api.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_api.cc

@@ -512,7 +512,8 @@ void CastChannelOpenFunction::CastMessageHandler::OnError(

scoped_ptr<base::ListValue> results =

OnError::Create(channel_info, error_info);

- scoped_ptr<Event> event(new Event(OnError::kEventName, results.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, OnError::kEventName, results.Pass()));

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(ui_dispatch_cb_, socket_->owner_extension_id(),

@@ -532,7 +533,8 @@ void CastChannelOpenFunction::CastMessageHandler::OnMessage(

scoped_ptr<base::ListValue> results =

OnMessage::Create(channel_info, message_info);

- scoped_ptr<Event> event(new Event(OnMessage::kEventName, results.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, OnMessage::kEventName, results.Pass()));

BrowserThread::PostTask(

BrowserThread::UI, FROM_HERE,

base::Bind(ui_dispatch_cb_, socket_->owner_extension_id(),