extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth/bluetooth_private_apitest.cc ('k') | extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

diff --git a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

index e1f59fb2cd44e8e271acb94cf95b65aa3d2c8c33..6884735ea73efb6099f394e8ff26cba5f423261c 100644

--- a/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

+++ b/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

@@ -866,8 +866,8 @@ void BluetoothLowEnergyEventRouter::GattServiceRemoved(

scoped_ptr<base::ListValue> args =

apibtle::OnServiceRemoved::Create(api_service);

- scoped_ptr<Event> event(

- new Event(apibtle::OnServiceRemoved::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, apibtle::OnServiceRemoved::kEventName, args.Pass()));

EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());

}

@@ -887,8 +887,8 @@ void BluetoothLowEnergyEventRouter::GattDiscoveryCompleteForService(

scoped_ptr<base::ListValue> args =

apibtle::OnServiceAdded::Create(api_service);

- scoped_ptr<Event> event(

- new Event(apibtle::OnServiceAdded::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(

+ events::UNKNOWN, apibtle::OnServiceAdded::kEventName, args.Pass()));

EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());

}

@@ -1160,7 +1160,8 @@ void BluetoothLowEnergyEventRouter::DispatchEventToExtensionsWithPermission(

// Send the event.

scoped_ptr<base::ListValue> args_copy(args->DeepCopy());

- scoped_ptr<Event> event(new Event(event_name, args_copy.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, event_name, args_copy.Pass()));

EventRouter::Get(browser_context_)->DispatchEventToExtension(

extension_id, event.Pass());

}