chrome/browser/speech/extension_api/tts_extension_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/extension_api/tts_extension_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/speech/extension_api/tts_engine_extension_api.cc ('k') | chrome/browser/ui/app_list/launcher_page_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/speech/extension_api/tts_extension_api.cc

diff --git a/chrome/browser/speech/extension_api/tts_extension_api.cc b/chrome/browser/speech/extension_api/tts_extension_api.cc

index adf8e7ce4183803d4cf76385a7d66f63a9dd4741..0ee077fb06e298966f19d218a8c2be97f65d66fb 100644

--- a/chrome/browser/speech/extension_api/tts_extension_api.cc

+++ b/chrome/browser/speech/extension_api/tts_extension_api.cc

@@ -135,8 +135,8 @@ void TtsExtensionEventHandler::OnTtsEvent(Utterance* utterance,

scoped_ptr<base::ListValue> arguments(new base::ListValue());

arguments->Set(0, details.release());

- scoped_ptr<extensions::Event> event(

- new extensions::Event(events::kOnEvent, arguments.Pass()));

+ scoped_ptr<extensions::Event> event(new extensions::Event(

+ ::extensions::events::UNKNOWN, ::events::kOnEvent, arguments.Pass()));

event->restrict_to_browser_context = utterance->browser_context();

event->event_url = utterance->src_url();

extensions::EventRouter::Get(utterance->browser_context())