Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3393)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaaaaase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index 95993c9906ec963d80a5a8d44210152a3ea07fcf..0075b9253016b26ecfd14137cd7d73c34873269c 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -697,8 +697,8 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,
{
// Dispatch to menu item's .onclick handler.
scoped_ptr<Event> event(
- new Event(webview_guest ? kOnWebviewContextMenus
- : kOnContextMenus,
+ new Event(events::UNKNOWN,
+ webview_guest ? kOnWebviewContextMenus : kOnContextMenus,
scoped_ptr<base::ListValue>(args->DeepCopy())));
event->restrict_to_browser_context = context;
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
@@ -706,10 +706,10 @@ void MenuManager::ExecuteCommand(content::BrowserContext* context,
}
{
// Dispatch to .contextMenus.onClicked handler.
- scoped_ptr<Event> event(
- new Event(webview_guest ? chrome_web_view::OnClicked::kEventName
- : context_menus::OnClicked::kEventName,
- args.Pass()));
+ scoped_ptr<Event> event(new Event(
+ events::UNKNOWN, webview_guest ? chrome_web_view::OnClicked::kEventName
+ : context_menus::OnClicked::kEventName,
+ args.Pass()));
event->restrict_to_browser_context = context;
event->user_gesture = EventRouter::USER_GESTURE_ENABLED;
if (webview_guest)
« no previous file with comments | « chrome/browser/extensions/extension_webui_apitest.cc ('k') | chrome/browser/extensions/permissions_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698