chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api.cc ('k') | chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

index 23f0f7feb2affde6e557a9754b5332ad05b0639d..c37eadbea93e4c891abcf61832acb311ca254ad5 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

@@ -80,9 +80,10 @@ void PasswordsPrivateEventRouter::SendSavedPasswordListToListeners() {

// If there is nothing to send, return early.

return;

- scoped_ptr<Event> extension_event(new Event(

- api::passwords_private::OnSavedPasswordsListChanged::kEventName,

- cached_saved_password_parameters_->CreateDeepCopy()));

+ scoped_ptr<Event> extension_event(

+ new Event(events::UNKNOWN,

+ api::passwords_private::OnSavedPasswordsListChanged::kEventName,

+ cached_saved_password_parameters_->CreateDeepCopy()));

event_router_->BroadcastEvent(extension_event.Pass());

}

@@ -100,6 +101,7 @@ void PasswordsPrivateEventRouter::SendPasswordExceptionListToListeners() {

return;

scoped_ptr<Event> extension_event(new Event(

+ events::UNKNOWN,

api::passwords_private::OnPasswordExceptionsListChanged::kEventName,

cached_password_exception_parameters_->CreateDeepCopy()));

event_router_->BroadcastEvent(extension_event.Pass());

@@ -118,6 +120,7 @@ void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(

event_value->Append(params.ToValue());

scoped_ptr<Event> extension_event(new Event(

+ events::UNKNOWN,

api::passwords_private::OnPlaintextPasswordRetrieved::kEventName,

event_value.Pass()));

event_router_->BroadcastEvent(extension_event.Pass());