chrome/browser/extensions/api/notification_provider/notification_provider_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_api.cc ('k') | chrome/browser/extensions/api/notifications/notifications_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

diff --git a/chrome/browser/extensions/api/notification_provider/notification_provider_api.cc b/chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

index 901f02fc48cef6c10d46fa085c5203c10e26513c..c07bfc1847d34ab0cfb88f43b43b21535c98cbd0 100644

--- a/chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

+++ b/chrome/browser/extensions/api/notification_provider/notification_provider_api.cc

@@ -65,7 +65,8 @@ void NotificationProviderEventRouter::Create(

sender_id, notification_id, options);

scoped_ptr<Event> event(new Event(

- api::notification_provider::OnCreated::kEventName, args.Pass()));

+ events::UNKNOWN, api::notification_provider::OnCreated::kEventName,

+ args.Pass()));

EventRouter::Get(profile_)

->DispatchEventToExtension(notification_provider_id, event.Pass());

@@ -81,7 +82,8 @@ void NotificationProviderEventRouter::Update(

sender_id, notification_id, options);

scoped_ptr<Event> event(new Event(

- api::notification_provider::OnUpdated::kEventName, args.Pass()));

+ events::UNKNOWN, api::notification_provider::OnUpdated::kEventName,

+ args.Pass()));

EventRouter::Get(profile_)

->DispatchEventToExtension(notification_provider_id, event.Pass());

@@ -95,7 +97,8 @@ void NotificationProviderEventRouter::Clear(

api::notification_provider::OnCleared::Create(sender_id, notification_id);

scoped_ptr<Event> event(new Event(

- api::notification_provider::OnCleared::kEventName, args.Pass()));

+ events::UNKNOWN, api::notification_provider::OnCleared::kEventName,

+ args.Pass()));

EventRouter::Get(profile_)

->DispatchEventToExtension(notification_provider_id, event.Pass());