chrome/browser/extensions/api/location/location_manager.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/location/location_manager.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/location/location_manager.cc

diff --git a/chrome/browser/extensions/api/location/location_manager.cc b/chrome/browser/extensions/api/location/location_manager.cc

index 142470127f65b53ee8908fdc92493e37c294e7a4..a5cd40f90f3019f4f3a555c8a924ef883105baeb 100644

--- a/chrome/browser/extensions/api/location/location_manager.cc

+++ b/chrome/browser/extensions/api/location/location_manager.cc

@@ -33,7 +33,7 @@ namespace updatepolicy {

// Base class for all update policies for sending a location.

class UpdatePolicy : public base::RefCounted<UpdatePolicy> {

public:

- explicit UpdatePolicy() {}

+ UpdatePolicy() {}

// True if the caller should send an update based off of this policy.

virtual bool ShouldSendUpdate(const content::Geoposition&) const = 0;

@@ -332,7 +332,7 @@ void LocationManager::SendLocationUpdate(

event_name = location::OnLocationError::kEventName;

}

- scoped_ptr<Event> event(new Event(event_name, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN, event_name, args.Pass()));

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_id, event.Pass());