chrome/browser/extensions/api/image_writer_private/operation_manager.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_manager.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/web_auth_flow.cc ('k') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_manager.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager.cc b/chrome/browser/extensions/api/image_writer_private/operation_manager.cc

index a924d26e0dbdfc1a4c9567f48c0d4e7e8ac66599..105c9773ea69bcc9dad0efcb4235c166817a00fa 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_manager.cc

+++ b/chrome/browser/extensions/api/image_writer_private/operation_manager.cc

@@ -160,8 +160,9 @@ void OperationManager::OnProgress(const ExtensionId& extension_id,

scoped_ptr<base::ListValue> args(

image_writer_api::OnWriteProgress::Create(info));

- scoped_ptr<Event> event(new Event(

- image_writer_api::OnWriteProgress::kEventName, args.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, image_writer_api::OnWriteProgress::kEventName,

+ args.Pass()));

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_id, event.Pass());

@@ -171,8 +172,9 @@ void OperationManager::OnComplete(const ExtensionId& extension_id) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

scoped_ptr<base::ListValue> args(image_writer_api::OnWriteComplete::Create());

- scoped_ptr<Event> event(new Event(

- image_writer_api::OnWriteComplete::kEventName, args.Pass()));

+ scoped_ptr<Event> event(

+ new Event(events::UNKNOWN, image_writer_api::OnWriteComplete::kEventName,

+ args.Pass()));

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_id, event.Pass());

@@ -194,8 +196,9 @@ void OperationManager::OnError(const ExtensionId& extension_id,

scoped_ptr<base::ListValue> args(

image_writer_api::OnWriteError::Create(info, error_message));

- scoped_ptr<Event> event(new Event(

- image_writer_api::OnWriteError::kEventName, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN,

+ image_writer_api::OnWriteError::kEventName,

+ args.Pass()));

EventRouter::Get(browser_context_)

->DispatchEventToExtension(extension_id, event.Pass());