chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

index 3bc4371f85918eef7dd5ad1d56287e0de0c6e52c..e7d5908de971644ef6273ec69c49661ace3252ad 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

@@ -84,7 +84,8 @@ void ExperienceSamplingEvent::CreateUserDecisionEvent(

args->Append(ui_element_.ToValue().release());

args->Append(decision.ToValue().release());

scoped_ptr<Event> event(new Event(

- api::experience_sampling_private::OnDecision::kEventName, args.Pass()));

+ events::UNKNOWN, api::experience_sampling_private::OnDecision::kEventName,

+ args.Pass()));

EventRouter* router = EventRouter::Get(browser_context_);

if (router)

router->BroadcastEvent(event.Pass());

@@ -98,6 +99,7 @@ void ExperienceSamplingEvent::CreateOnDisplayedEvent() {

scoped_ptr<base::ListValue> args(new base::ListValue());

args->Append(ui_element_.ToValue().release());

scoped_ptr<Event> event(new Event(

+ events::UNKNOWN,

api::experience_sampling_private::OnDisplayed::kEventName, args.Pass()));

EventRouter* router = EventRouter::Get(browser_context_);

if (router)