chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/automation_internal/automation_util.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

index 8d0c372cb1de9e77d82b8768240c1694f16f431e..9e867255690006be1391a3c81d36dd4965d7deba 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

@@ -186,8 +186,9 @@ BookmarkManagerPrivateEventRouter::~BookmarkManagerPrivateEventRouter() {

void BookmarkManagerPrivateEventRouter::DispatchEvent(

const std::string& event_name,

scoped_ptr<base::ListValue> event_args) {

- extensions::EventRouter::Get(browser_context_)->BroadcastEvent(

- make_scoped_ptr(new extensions::Event(event_name, event_args.Pass())));

+ extensions::EventRouter::Get(browser_context_)

+ ->BroadcastEvent(make_scoped_ptr(new extensions::Event(

+ extensions::events::UNKNOWN, event_name, event_args.Pass())));

}

void BookmarkManagerPrivateEventRouter::BookmarkModelChanged() {}

@@ -303,7 +304,7 @@ void BookmarkManagerPrivateDragEventRouter::DispatchEvent(

if (!event_router)

return;

- scoped_ptr<Event> event(new Event(event_name, args.Pass()));

+ scoped_ptr<Event> event(new Event(events::UNKNOWN, event_name, args.Pass()));

event_router->BroadcastEvent(event.Pass());

}