chrome/browser/copresence/chrome_whispernet_client.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/copresence/chrome_whispernet_client.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaaaaase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printer_detector/printer_detector.cc ('k') | chrome/browser/extensions/api/activity_log_private/activity_log_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/copresence/chrome_whispernet_client.cc

diff --git a/chrome/browser/copresence/chrome_whispernet_client.cc b/chrome/browser/copresence/chrome_whispernet_client.cc

index 116e69ecf2fceecf1466600c2290c63f066c79c7..321012fc83106b19e2a2bb034e7b4ef4ab17b297 100644

--- a/chrome/browser/copresence/chrome_whispernet_client.cc

+++ b/chrome/browser/copresence/chrome_whispernet_client.cc

@@ -133,9 +133,8 @@ void ChromeWhispernetClient::EncodeToken(

ConvertTokenParams(token_params[type], &params.token_params);

SendEventIfLoaded(make_scoped_ptr(new Event(

- OnEncodeTokenRequest::kEventName,

- OnEncodeTokenRequest::Create(client_id_, params),

- browser_context_)));

+ extensions::events::UNKNOWN, OnEncodeTokenRequest::kEventName,

+ OnEncodeTokenRequest::Create(client_id_, params), browser_context_)));

}

void ChromeWhispernetClient::DecodeSamples(

@@ -150,9 +149,8 @@ void ChromeWhispernetClient::DecodeSamples(

ConvertTokenParams(token_params[INAUDIBLE], &params.inaudible_token_params);

SendEventIfLoaded(make_scoped_ptr(new Event(

- OnDecodeSamplesRequest::kEventName,

- OnDecodeSamplesRequest::Create(client_id_, params),

- browser_context_)));

+ extensions::events::UNKNOWN, OnDecodeSamplesRequest::kEventName,

+ OnDecodeSamplesRequest::Create(client_id_, params), browser_context_)));

}

void ChromeWhispernetClient::RegisterTokensCallback(

@@ -192,9 +190,8 @@ void ChromeWhispernetClient::AudioConfiguration(const AudioParamData& params) {

DVLOG(3) << "Configuring audio for client " << client_id_;

SendEventIfLoaded(make_scoped_ptr(new Event(

- OnConfigAudio::kEventName,

- OnConfigAudio::Create(client_id_, audio_params),

- browser_context_)));

+ extensions::events::UNKNOWN, OnConfigAudio::kEventName,

+ OnConfigAudio::Create(client_id_, audio_params), browser_context_)));

}

void ChromeWhispernetClient::SendEventIfLoaded(