chrome/browser/signin/easy_unlock_app_manager.cc - Issue 1201063002: Set up the infrastructure for Extension event metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_app_manager.cc

Issue 1201063002: Set up the infrastructure for Extension event metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/signin/easy_unlock_service_regular.cc » ('j') | extensions/browser/event_router.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/easy_unlock_app_manager.cc

diff --git a/chrome/browser/signin/easy_unlock_app_manager.cc b/chrome/browser/signin/easy_unlock_app_manager.cc

index 06ee826b085da2344911211df157b9e1a3185f79..f389954f6512cd5a0856f1a9c0df3d5690d30c80 100644

--- a/chrome/browser/signin/easy_unlock_app_manager.cc

+++ b/chrome/browser/signin/easy_unlock_app_manager.cc

@@ -161,8 +161,8 @@ bool EasyUnlockAppManagerImpl::SendUserUpdatedEvent(const std::string& user_id,

scoped_ptr<base::ListValue> args(new base::ListValue());

args->Append(info.ToValue().release());

- scoped_ptr<extensions::Event> event(

- new extensions::Event(event_name, args.Pass()));

+ scoped_ptr<extensions::Event> event(new extensions::Event(

+ extensions::events::UNKNOWN, event_name, args.Pass()));

event_router->DispatchEventToExtension(app_id_, event.Pass());

return true;

@@ -189,8 +189,8 @@ bool EasyUnlockAppManagerImpl::SendAuthAttemptEvent() {

extensions::api::screenlock_private::AUTH_TYPE_USERCLICK));

args->AppendString(std::string());

- scoped_ptr<extensions::Event> event(

- new extensions::Event(event_name, args.Pass()));

+ scoped_ptr<extensions::Event> event(new extensions::Event(

+ extensions::events::UNKNOWN, event_name, args.Pass()));

// TODO(tbarzic): Restrict this to EasyUnlock app.

event_router->BroadcastEvent(event.Pass());