Issue 1201023002: Subzero: Use more "= default;" for ctors and dtors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1201023002: Subzero: Use more "= default;" for ctors and dtors. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Use more "= default;" for ctors and dtors. Look for "() override {}" and "() final {}" patterns. Don't touch IceTargetLoweringX8632.* to spare a refactoring in progress. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e587d9494fa95920943fafa0f1dac470a298a251

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	src/IceCompileServer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTargetLoweringARM32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/IceTargetLoweringMIPS32.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/PNaClTranslator.cpp	View	8 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 6 months ago (2015-06-22 22:49:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e587d9494fa95920943fafa0f1dac470a298a251 (presubmit successful).