Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: sky/tools/shelldb

Issue 1200993002: Update README.md and HACKING.md and resulting yak shave. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tools/shelldb
diff --git a/sky/tools/shelldb b/sky/tools/shelldb
index ae6d7844b7344fa956268f0d7e546f009b7c7fec..138eb39bd2565307fd187db879b6911026d0965c 100755
--- a/sky/tools/shelldb
+++ b/sky/tools/shelldb
@@ -174,11 +174,8 @@ class StartSky(object):
return server_root
def _sky_server_for_args(self, args, packages_root):
- # FIXME: This is a hack. sky_server should just take a build_dir
- # not a magical "configuration" name.
- configuration = os.path.basename(os.path.normpath(args.build_dir))
server_root = self._server_root_for_url(args.url_or_path)
- sky_server = SkyServer(SKY_SERVER_PORT, configuration, server_root, packages_root)
+ sky_server = SkyServer(SKY_SERVER_PORT, server_root, packages_root)
return sky_server
def _find_remote_pid_for_package(self, package):

Powered by Google App Engine
This is Rietveld 408576698