Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: src/compiler/graph-reducer.cc

Issue 1200983004: Revert of [turbofan] Run DeadCodeElimination together with the advanced reducers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph-reducer.h ('k') | src/compiler/js-intrinsic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-reducer.cc
diff --git a/src/compiler/graph-reducer.cc b/src/compiler/graph-reducer.cc
index 80b40a7d9ac516f56aef21b6081d2f789ac329e2..33d400b61e1a736505b3a67111ff7f1187e05ef5 100644
--- a/src/compiler/graph-reducer.cc
+++ b/src/compiler/graph-reducer.cc
@@ -22,9 +22,11 @@
};
-GraphReducer::GraphReducer(Zone* zone, Graph* graph, Node* dead)
+GraphReducer::GraphReducer(Zone* zone, Graph* graph, Node* dead_value,
+ Node* dead_control)
: graph_(graph),
- dead_(dead),
+ dead_value_(dead_value),
+ dead_control_(dead_control),
state_(graph, 4),
reducers_(zone),
revisit_(zone),
@@ -203,15 +205,17 @@
// Requires distinguishing between value, effect and control edges.
for (Edge edge : node->use_edges()) {
- Node* const user = edge.from();
- DCHECK(!user->IsDead());
+ Node* user = edge.from();
if (NodeProperties::IsControlEdge(edge)) {
if (user->opcode() == IrOpcode::kIfSuccess) {
Replace(user, control);
} else if (user->opcode() == IrOpcode::kIfException) {
- DCHECK_NOT_NULL(dead_);
- edge.UpdateTo(dead_);
- Revisit(user);
+ for (Edge e : user->use_edges()) {
+ if (NodeProperties::IsValueEdge(e)) e.UpdateTo(dead_value_);
+ if (NodeProperties::IsEffectEdge(e)) e.UpdateTo(graph()->start());
+ if (NodeProperties::IsControlEdge(e)) e.UpdateTo(dead_control_);
+ }
+ edge.UpdateTo(user);
} else {
UNREACHABLE();
}
« no previous file with comments | « src/compiler/graph-reducer.h ('k') | src/compiler/js-intrinsic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698