Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: sky/viewer/internals.cc

Issue 1200953007: Move internals.dart out of Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: _____ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/bindings/BUILD.gn ('K') | « sky/tools/skyanalyzer ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/internals.cc
diff --git a/sky/viewer/internals.cc b/sky/viewer/internals.cc
index 2e825edf782725a64c2d67d49ba696c564eb3fc6..79ce138a0e9f5d5c831a5606f65edf557761cfa3 100644
--- a/sky/viewer/internals.cc
+++ b/sky/viewer/internals.cc
@@ -92,28 +92,14 @@ const uint8_t* Symbolizer(Dart_NativeFunction native_function) {
const char kLibraryName[] = "dart:sky.internals";
-// When editing this, also update sky/sdk/lib/internals.dart
-// so that the analyzer can see it
-const char kLibrarySource[] = R"DART(
-String contentAsText() native "contentAsText";
-String renderTreeAsText() native "renderTreeAsText";
-void notifyTestComplete(String test_result) native "notifyTestComplete";
-int takeShellProxyHandle() native "takeShellProxyHandle";
-int takeServicesProvidedByEmbedder() native "takeServicesProvidedByEmbedder";
-int takeServicesProvidedToEmbedder() native "takeServicesProvidedToEmbedder";
-int takeServiceRegistry() native "takeServiceRegistry";
-)DART";
-
} // namespace
void Internals::Create(Dart_Isolate isolate, DocumentView* document_view) {
DartState* state = DartState::From(isolate);
state->SetUserData(&kInternalsKey, new Internals(document_view));
Dart_Handle library =
- Dart_LoadLibrary(Dart_NewStringFromCString(kLibraryName),
- Dart_NewStringFromCString(kLibrarySource), 0, 0);
+ Dart_LookupLibrary(Dart_NewStringFromCString(kLibraryName));
CHECK(!LogIfError(library));
- CHECK(!LogIfError(Dart_FinalizeLoading(true)));
CHECK(!LogIfError(Dart_SetNativeResolver(library, Resolver, Symbolizer)));
}
« sky/engine/bindings/BUILD.gn ('K') | « sky/tools/skyanalyzer ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698