Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: sky/shell/ui/internals.cc

Issue 1200953007: Move internals.dart out of Sky SDK (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: _____ Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/shell/ui/internals.cc
diff --git a/sky/shell/ui/internals.cc b/sky/shell/ui/internals.cc
index 676f3521ba9ca2215db736b46aa0a542ed92f5cb..a7555afa8ca6e106f7fdabf22a008afd4a2afb00 100644
--- a/sky/shell/ui/internals.cc
+++ b/sky/shell/ui/internals.cc
@@ -52,9 +52,6 @@ const uint8_t* Symbolizer(Dart_NativeFunction native_function) {
}
const char kLibraryName[] = "dart:sky.internals";
-const char kLibrarySource[] = R"DART(
-int takeServicesProvidedByEmbedder() native "takeServicesProvidedByEmbedder";
-)DART";
} // namespace
@@ -63,10 +60,8 @@ void Internals::Create(Dart_Isolate isolate,
DartState* state = DartState::From(isolate);
state->SetUserData(&kInternalsKey, new Internals(service_provider.Pass()));
Dart_Handle library =
- Dart_LoadLibrary(Dart_NewStringFromCString(kLibraryName),
- Dart_NewStringFromCString(kLibrarySource), 0, 0);
+ Dart_LookupLibrary(Dart_NewStringFromCString(kLibraryName));
CHECK(!LogIfError(library));
- CHECK(!LogIfError(Dart_FinalizeLoading(true)));
CHECK(!LogIfError(Dart_SetNativeResolver(library, Resolver, Symbolizer)));
}

Powered by Google App Engine
This is Rietveld 408576698