Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 1200953002: Add proguard pre-processing of google_play_services. (Closed)

Created:
5 years, 6 months ago by Yaron
Modified:
5 years, 6 months ago
Reviewers:
cjhopman, Dirk Pranke
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proguard pre-processing of google_play_services. The GN build was missing the proguarding directives. Update to match gyp. BUG=502891 Committed: https://crrev.com/daa7193c7f0573fe4135404e134db060348dde8c Cr-Commit-Position: refs/heads/master@{#335594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yaron
5 years, 6 months ago (2015-06-22 19:00:03 UTC) #2
Dirk Pranke
lgtm, though you probably still need cjhopman's approval as well.
5 years, 6 months ago (2015-06-22 20:47:10 UTC) #4
Yaron
On 2015/06/22 20:47:10, Dirk Pranke wrote: > lgtm, though you probably still need cjhopman's approval ...
5 years, 6 months ago (2015-06-23 00:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200953002/1
5 years, 6 months ago (2015-06-23 00:29:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 00:34:58 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 00:35:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daa7193c7f0573fe4135404e134db060348dde8c
Cr-Commit-Position: refs/heads/master@{#335594}

Powered by Google App Engine
This is Rietveld 408576698