Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1200913002: Deprecate old HTML support (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index b093d337834ea77881fada63aa9505f181f84394..ac007d4751199bce91a043499d41cc2df3582101 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -21,7 +21,7 @@ import 'package:analyzer/src/generated/engine.dart'
UniversalCachePartition,
WorkManager;
import 'package:analyzer/src/generated/error.dart';
-import 'package:analyzer/src/generated/html.dart' as ht;
+import 'package:analyzer/src/generated/html.dart' as ht show HtmlUnit;
import 'package:analyzer/src/generated/incremental_resolver.dart';
import 'package:analyzer/src/generated/java_core.dart';
import 'package:analyzer/src/generated/java_engine.dart';
@@ -577,11 +577,11 @@ class AnalysisContextImpl implements InternalAnalysisContext {
_computeResult(source, EXPORTED_LIBRARIES);
@override
+ @deprecated
HtmlElement computeHtmlElement(Source source) {
- // TODO(brianwilkerson) Implement this. For the time being, we compute the
- // data that will implicitly be computed by creating an element.
- _computeResult(source, REFERENCED_LIBRARIES);
- return null;
+ // TODO(brianwilkerson) Remove this method after switching to the new task
+ // model.
+ throw new UnimplementedError('Not supported in the new task model');
}
@override
@@ -758,9 +758,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
return element;
}
- if (AnalysisEngine.isHtmlFileName(sourceName)) {
- return computeHtmlElement(source);
- }
} catch (exception) {
// If the location cannot be decoded for some reason then the underlying
// cause should have been logged already and we can fall though to return
@@ -783,13 +780,11 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
@override
+ @deprecated
HtmlElement getHtmlElement(Source source) {
- // TODO(brianwilkerson) Implement this.
-// SourceEntry sourceEntry = getReadableSourceEntryOrNull(source);
-// if (sourceEntry is HtmlEntry) {
-// return sourceEntry.getValue(HtmlEntry.ELEMENT);
-// }
- return null;
+ // TODO(brianwilkerson) Remove this method after switching to the new task
+ // model.
+ throw new UnimplementedError('Not supported in the new task model');
}
@override
@@ -924,14 +919,11 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
@override
+ @deprecated
ht.HtmlUnit getResolvedHtmlUnit(Source htmlSource) {
- // TODO(brianwilkerson) Implement this.
-// SourceEntry sourceEntry = getReadableSourceEntryOrNull(htmlSource);
-// if (sourceEntry is HtmlEntry) {
-// HtmlEntry htmlEntry = sourceEntry;
-// return htmlEntry.getValue(HtmlEntry.RESOLVED_UNIT);
-// }
- return null;
+ // TODO(brianwilkerson) Remove this method after switching to the new task
+ // model.
+ throw new UnimplementedError('Not supported in the new task model');
}
@override
@@ -1042,8 +1034,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {
ht.HtmlUnit parseHtmlUnit(Source source) {
// TODO(brianwilkerson) Remove this method after switching to the new task
// model.
- throw new UnimplementedError(
- 'Not supported in the new task model; use parseHtmlDocument instead.');
+ throw new UnimplementedError('Not supported in the new task model');
}
@override
@@ -1154,7 +1145,8 @@ class AnalysisContextImpl implements InternalAnalysisContext {
@override
@deprecated
ht.HtmlUnit resolveHtmlUnit(Source htmlSource) {
- computeHtmlElement(htmlSource);
+ // TODO(brianwilkerson) Remove this method after switching to the new task
+ // model.
throw new UnimplementedError('Not supported in the new task model');
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698