Source/devtools/front_end/emulation/ResponsiveDesignView.js - Issue 1200903003: [DevTools] Pass screen size and position to setDeviceMetricsOverrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/emulation/ResponsiveDesignView.js

Issue 1200903003: [DevTools] Pass screen size and position to setDeviceMetricsOverrides. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/emulation/ResponsiveDesignView.js

diff --git a/Source/devtools/front_end/emulation/ResponsiveDesignView.js b/Source/devtools/front_end/emulation/ResponsiveDesignView.js

index cb2f06beb60e676720cf5fbb454bc3f2c39ea46d..0e445bf608f3dae9e062a216e620c21164b6790d 100644

--- a/Source/devtools/front_end/emulation/ResponsiveDesignView.js

+++ b/Source/devtools/front_end/emulation/ResponsiveDesignView.js

@@ -618,8 +618,7 @@ WebInspector.ResponsiveDesignView.prototype = {

var fieldsetElement = deviceElement.createChild("fieldset");

fieldsetElement.createChild("label").textContent = WebInspector.UIString("Device");

- var deviceSelect = new WebInspector.DeviceSelect(createElementWithClass("button", "responsive-design-icon responsive-design-icon-swap"));

- deviceSelect.setCallback(this._deviceModeSelected.bind(this));

+ var deviceSelect = new WebInspector.DeviceSelect(createElementWithClass("button", "responsive-design-icon responsive-design-icon-swap"), this._deviceModeSelected.bind(this));

fieldsetElement.appendChild(deviceSelect.element);

deviceSelect.element.classList.add("responsive-design-device-select");

« no previous file with comments | « Source/devtools/front_end/emulation/OverridesView.js ('k') | no next file » | no next file with comments »