Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2291)

Unified Diff: Source/devtools/front_end/emulation/OverridesSupport.js

Issue 1200903003: [DevTools] Pass screen size and position to setDeviceMetricsOverrides. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/emulation/OverridesUI.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/emulation/OverridesSupport.js
diff --git a/Source/devtools/front_end/emulation/OverridesSupport.js b/Source/devtools/front_end/emulation/OverridesSupport.js
index 261f037161bfd062a57b8c611b7b0049db53cc10..52869577d6338d9fd9b35fc93a4ed19832414e80 100644
--- a/Source/devtools/front_end/emulation/OverridesSupport.js
+++ b/Source/devtools/front_end/emulation/OverridesSupport.js
@@ -556,6 +556,10 @@ WebInspector.OverridesSupport.prototype = {
var overrideWidth = dipWidth;
var overrideHeight = dipHeight;
+ var screenWidth = dipWidth;
+ var screenHeight = dipHeight;
+ var positionX = 0;
+ var positionY = 0;
var scale = 1;
if (this._pageResizer) {
var available = this._pageResizerAvailableSize;
@@ -580,6 +584,10 @@ WebInspector.OverridesSupport.prototype = {
overrideWidth = Math.round(available.width / scale);
if (dipHeight === 0 && dipWidth !== 0)
overrideHeight = Math.round(available.height / scale);
+ screenWidth = dipWidth + insets.left + insets.right;
+ screenHeight = dipHeight + insets.top + insets.bottom;
+ positionX = insets.left;
+ positionY = insets.top;
}
this._deviceScale = scale;
@@ -594,6 +602,7 @@ WebInspector.OverridesSupport.prototype = {
this._target.emulationAgent().setDeviceMetricsOverride(
overrideWidth, overrideHeight, this.settings.emulateResolution.get() ? this.settings.deviceScaleFactor.get() : 0,
this.settings.emulateMobile.get(), this._pageResizer ? false : this.settings.deviceFitWindow.get(), scale, 0, 0,
+ screenWidth, screenHeight, positionX, positionY,
apiCallback.bind(this, finishCallback));
}
« no previous file with comments | « no previous file | Source/devtools/front_end/emulation/OverridesUI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698