Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1200903003: [DevTools] Pass screen size and position to setDeviceMetricsOverrides. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Pass screen size and position to setDeviceMetricsOverrides. BUG=393493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M Source/devtools/front_end/emulation/OverridesSupport.js View 3 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesUI.js View 2 chunks +3 lines, -10 lines 0 comments Download
M Source/devtools/front_end/emulation/OverridesView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
PTAL
4 years, 10 months ago (2015-06-22 17:03:27 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-22 17:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200903003/1
4 years, 10 months ago (2015-06-24 11:35:08 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-24 13:53:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200903003/1
4 years, 10 months ago (2015-06-24 14:11:42 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 16:33:50 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197756

Powered by Google App Engine
This is Rietveld 408576698