Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: third_party/cq_client/README.md

Issue 1200863002: Update cq_client and add validate command to commit_queue binary (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « commit_queue.py ('k') | third_party/cq_client/test/cq_example.cfg » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cq_client/README.md
diff --git a/third_party/cq_client/README.md b/third_party/cq_client/README.md
new file mode 100644
index 0000000000000000000000000000000000000000..0822d116875788f0ca3060ba2ae37d801281e63f
--- /dev/null
+++ b/third_party/cq_client/README.md
@@ -0,0 +1,13 @@
+This directory contains CQ client library to be distributed to other repos. If
+you need to modify some files in this directory, please make sure that you are
+changing the original version in the source code and not to one of the copies,
Adrian Kuegel 2015/06/22 13:04:59 I think this should be: "that you are changing the
Sergiy Byelozyorov 2015/06/22 17:02:36 Done.
+which should only be updated as a whole using Glyco (when available).
+
+To generate `cq_pb2.py`, please use protoc version 2.6.1:
+
+ cd commit_queue/cq_client
+ protoc cq.proto --python_out $(pwd)
+
+Additionally, please make sure to use proto3-compatible syntax, e.g. no default
+values, no required fields. Ideally, we should use proto3 generator already,
+however alpha version thereof is still unstable.
« no previous file with comments | « commit_queue.py ('k') | third_party/cq_client/test/cq_example.cfg » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698