Update cq_client and add validate command to commit_queue binary

Update cq_client and add validate command to commit_queue binary

R=akuegel@chromium.org, pgervais@chromium.org
BUG=472612, 503068
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295818

[Adrian Kuegel, 2015-06-22 13:04:59]

LGTM with nits

https://codereview.chromium.org/1200863002/diff/20001/third_party/cq_client/R...
File third_party/cq_client/README.md (right):

https://codereview.chromium.org/1200863002/diff/20001/third_party/cq_client/R...
third_party/cq_client/README.md:3: changing the original version in the source
code and not to one of the copies,
I think this should be: "that you are changing the originial version of the
source code" (i.e. "of" instead of "in").
Also, "not to one" should be replaced by "not one".

[Sergiy Byelozyorov, 2015-06-22 17:02:36]

https://codereview.chromium.org/1200863002/diff/20001/third_party/cq_client/R...
File third_party/cq_client/README.md (right):

https://codereview.chromium.org/1200863002/diff/20001/third_party/cq_client/R...
third_party/cq_client/README.md:3: changing the original version in the source
code and not to one of the copies,
On 2015/06/22 13:04:59, Adrian Kuegel wrote:
> I think this should be: "that you are changing the originial version of the
> source code" (i.e. "of" instead of "in").
> Also, "not to one" should be replaced by "not one".

Done.

[pgervais, 2015-06-24 01:10:43]

A few comments, but lgtm otherwise. Feel free to commit after addressing the
comments.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/commit_queue.py
File commit_queue.py (right):

https://chromiumcodereview.appspot.com/1200863002/diff/100001/commit_queue.py...
commit_queue.py:162: return 0 if validate_config.IsValid(cq_config) else 1
Nit: this should live outside the with statement

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
File third_party/cq_client/validate_config.py (right):

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:48: field_path: Path to the target
field separated with ".".
Nit: add the type of the arguments.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:105: except Exception:
expect re.error:

instead. We don't want to catch everything.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:111: return False
Why are you checking that again? rietveld.url is in REQUIRED_FIELDS.

[Sergiy Byelozyorov, 2015-06-24 05:30:59]

https://chromiumcodereview.appspot.com/1200863002/diff/100001/commit_queue.py
File commit_queue.py (right):

https://chromiumcodereview.appspot.com/1200863002/diff/100001/commit_queue.py...
commit_queue.py:162: return 0 if validate_config.IsValid(cq_config) else 1
On 2015/06/24 01:10:43, pgervais wrote:
> Nit: this should live outside the with statement

Done.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
File third_party/cq_client/validate_config.py (right):

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:48: field_path: Path to the target
field separated with ".".
On 2015/06/24 01:10:43, pgervais wrote:
> Nit: add the type of the arguments.

Done.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:105: except Exception:
On 2015/06/24 01:10:43, pgervais wrote:
> expect re.error:
> 
> instead. We don't want to catch everything. 

Done.

https://chromiumcodereview.appspot.com/1200863002/diff/100001/third_party/cq_...
third_party/cq_client/validate_config.py:111: return False
On 2015/06/24 01:10:43, pgervais wrote:
> Why are you checking that again? rietveld.url is in REQUIRED_FIELDS. 

Done.

[Sergiy Byelozyorov, 2015-06-24 05:33:29]

The CQ bit was checked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2015-06-24 05:33:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
akuegel@chromium.org, pgervais@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1200863002/#ps120001 (title: "Addressed
comments")

[commit-bot: I haz the power, 2015-06-24 05:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200863002/120001

[Sergiy Byelozyorov, 2015-06-24 05:34:25]

The CQ bit was unchecked by sergiyb@chromium.org

[Sergiy Byelozyorov, 2015-06-24 05:35:54]

On 2015/06/24 01:10:43, pgervais wrote:
> A few comments, but lgtm otherwise. Feel free to commit after addressing the
> comments.

I can only land this after https://chromereviews.googleplex.com/212347013/.
Since you reviewed the code here, I'll assume I also have your lgtm there, but
will still wait for Pawel's LGTM.

[Sergiy Byelozyorov, 2015-06-24 13:39:17]

The CQ bit was checked by sergiyb@chromium.org

[commit-bot: I haz the power, 2015-06-24 13:39:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200863002/120001

[commit-bot: I haz the power, 2015-06-24 13:41:46]

Committed patchset #7 (id:120001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295818