HTMLSelectElement size type changed to unsigned

HTMLSelectElement size type changed to unsigned

Changes include in LayoutListBox as its value is based on size value.

BUG=496400
R=philipj@opera.com, keishi

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197636

[Habib Virji, 2015-06-22 14:24:18]

The CQ bit was checked by habib.virji@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-22 14:24:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200853003/1

[commit-bot: I haz the power, 2015-06-22 15:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 15:30:42]

Dry run: This issue passed the CQ dry run.

[Habib Virji, 2015-06-22 15:47:43]

PTAL.

[keishi, 2015-06-22 16:35:16]

LGTM

[Habib Virji, 2015-06-23 08:08:03]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2015-06-23 08:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200853003/1

[commit-bot: I haz the power, 2015-06-23 08:11:38]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197636

[philipj_slow, 2015-06-23 08:51:38]

This change should have been accompanied by a test case, as the change should be
observable, when setting select.size = -1, the size content attribute should be
UINT_MAX or something. Please add a test in a follow-up CL.

[Habib Virji, 2015-06-25 13:26:23]

On 2015/06/23 08:51:38, philipj wrote:
> This change should have been accompanied by a test case, as the change should
be
> observable, when setting select.size = -1, the size content attribute should
be
> UINT_MAX or something. Please add a test in a follow-up CL.

I did try implementing the test case you suggested, and it returns 0 when value
is -1. 

Should a submit a CL with just a test case or include it part of other CL where
i am fixing other todo of the HTMLSelectElement.

[philipj_slow, 2015-06-26 14:20:39]

On 2015/06/25 13:26:23, Habib Virji wrote:
> On 2015/06/23 08:51:38, philipj wrote:
> > This change should have been accompanied by a test case, as the change
should
> be
> > observable, when setting select.size = -1, the size content attribute should
> be
> > UINT_MAX or something. Please add a test in a follow-up CL.
> 
> I did try implementing the test case you suggested, and it returns 0 when
value
> is -1. 
> 
> Should a submit a CL with just a test case or include it part of other CL
where
> i am fixing other todo of the HTMLSelectElement.

A test and fix together sounds good, even if part of the test is actually for
the change in this CL.