Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1200833006: DevTools: [Elements] F2 should commit changes in edit-as-html (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: [Elements] F2 should commit changes in edit-as-html BUG=493091 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197645

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeElement.js View 1 1 chunk +8 lines, -16 lines 0 comments Download
M Source/devtools/front_end/ui/InplaceEditor.js View 5 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
lushnikov
4 years, 10 months ago (2015-06-22 16:55:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833006/1
4 years, 10 months ago (2015-06-22 16:55:56 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/1200833006/diff/1/Source/devtools/front_end/elements/ElementsTreeElement.js File Source/devtools/front_end/elements/ElementsTreeElement.js (right): https://codereview.chromium.org/1200833006/diff/1/Source/devtools/front_end/elements/ElementsTreeElement.js#newcode849 Source/devtools/front_end/elements/ElementsTreeElement.js:849: if (event.keyCode === WebInspector.KeyboardShortcut.Keys.F2.code) I'd move this to ...
4 years, 10 months ago (2015-06-22 17:59:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-22 18:03:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833006/1
4 years, 10 months ago (2015-06-22 18:16:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197588
4 years, 10 months ago (2015-06-22 18:21:20 UTC) #9
lushnikov
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1196343002/ by lushnikov@chromium.org. ...
4 years, 10 months ago (2015-06-22 18:28:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833006/20001
4 years, 10 months ago (2015-06-23 12:06:46 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 13:01:10 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197645

Powered by Google App Engine
This is Rietveld 408576698