Apps&Extensions for Supervised Users: send permission request on outdated re-enables

chrome/browser/supervised_user/supervised_user_service.cc

Index: chrome/browser/supervised_user/supervised_user_service.cc
diff --git a/chrome/browser/supervised_user/supervised_user_service.cc b/chrome/browser/supervised_user/supervised_user_service.cc
index 5ea32d6abb86fa043b8f5d3f8f2e91965d0a8370..46f16b1a24fce1872ea9b7527385184b0fe39674 100644
--- a/chrome/browser/supervised_user/supervised_user_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_service.cc
@@ -109,6 +109,11 @@ void CreateExtensionUpdateRequest(
   creator->CreateExtensionUpdateRequest(id, callback);
 }
 
+// Default callback for AddExtensionUpdateRequest.
+void ExtensionUpdateRequestSent(const std::string& id, bool success) {
+  LOG_IF(WARNING, !success) << "Failed sending update request for " << id;

[Devlin, 2015/10/16 02:40:24]

LOGs are annoying.  We never read them, except when it's something random that
happens and no one understands it.  When can this happen?

If it shouldn't (ever), (D)CHECK.  If it can and we care about metrics/knowing
about it, UMA it.  If it can and we just don't know what to do, but feel bad
doing nothing, make it a VLOG.

[Marc Treib, 2015/10/16 09:22:20]

It can happen when the server we talk to is down, etc. I think it's rare enough
that it won't be annoying, but eh. It's now a VLOG.

+}
+
 base::FilePath GetBlacklistPath() {
   base::FilePath blacklist_dir;
   PathService::Get(chrome::DIR_USER_DATA, &blacklist_dir);
@@ -252,6 +257,15 @@ void SupervisedUserService::AddExtensionUpdateRequest(
       callback, 0);
 }
 
+void SupervisedUserService::AddExtensionUpdateRequest(
+    const std::string& extension_id,
+    const base::Version& version) {
+  AddExtensionUpdateRequest(
+      extension_id, version,
+      base::Bind(ExtensionUpdateRequestSent,
+                 extension_id + ":" + version.GetString()));

[Devlin, 2015/10/16 02:40:24]

nitty nit: prefer base::StringPrintf for times like this.

[Marc Treib, 2015/10/16 09:22:20]

Done.

+}
+
 std::string SupervisedUserService::GetCustodianEmailAddress() const {
   std::string email = profile_->GetPrefs()->GetString(
       prefs::kSupervisedUserCustodianEmail);