Apps&Extensions for Supervised Users: send permission request on outdated re-enables

chrome/browser/supervised_user/supervised_user_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_
 #define CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 99 matching lines @@
   bool AccessRequestsEnabled();
 
   // Adds an access request for the given URL.
   void AddURLAccessRequest(const GURL& url, const SuccessCallback& callback);
 
   // Adds an update request for the given WebStore item (App/Extension).
   void AddExtensionUpdateRequest(const std::string& extension_id,
                                  const base::Version& version,
                                  const SuccessCallback& callback);
 
+  // Same as above, but without a callback, for when the caller doesn't care

[Devlin, 2015/10/16 02:40:24]

Some of this comment seems unnecessary - I think the "for when the caller
doesn't care about the result" is implied by the lack of callback. ;)

How about just "Same as above, but without a callback, just logging errors on
failure."

[Marc Treib, 2015/10/16 09:22:21]

Done.

+  // about the result. This will just log any errors.
+  void AddExtensionUpdateRequest(const std::string& extension_id,
+                                 const base::Version& version);
+
   // Returns the email address of the custodian.
   std::string GetCustodianEmailAddress() const;
 
   // Returns the name of the custodian, or the email address if the name is
   // empty.
   std::string GetCustodianName() const;
 
   // Returns the email address of the second custodian, or the empty string
   // if there is no second custodian.
   std::string GetSecondCustodianEmailAddress() const;
@@ skipping 233 matching lines @@
 
   // Used to create permission requests.
   ScopedVector<PermissionRequestCreator> permissions_creators_;
 
   base::ObserverList<SupervisedUserServiceObserver> observer_list_;
 
   base::WeakPtrFactory<SupervisedUserService> weak_ptr_factory_;
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_