Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: src/heap/heap-inl.h

Issue 1200833003: Fix wrong DCHECK in Heap::FindAllocationMemento where bump pointer overflow points to the currently… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index b170e04798eaf4bba8d86db01e723337b02f1cb1..fdb1d7345b4d79c0e738f39ab879667f4e604048 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -452,7 +452,7 @@ AllocationMemento* Heap::FindAllocationMemento(HeapObject* object) {
Address top = NewSpaceTop();
DCHECK(memento_address == top ||
memento_address + HeapObject::kHeaderSize <= top ||
- !NewSpacePage::OnSamePage(memento_address, top));
+ !NewSpacePage::OnSamePage(memento_address, top - 1));
if (memento_address == top) return NULL;
AllocationMemento* memento = AllocationMemento::cast(candidate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698