Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1200833003: Fix wrong DCHECK in Heap::FindAllocationMemento where bump pointer overflow points to the currently… (Closed)

Created:
5 years, 6 months ago by Hannes Payer (out of office)
Modified:
5 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix wrong DCHECK in Heap::FindAllocationMemento where bump pointer overflow points to the currently used new space page. BUG=chromium:501693 LOG=n Committed: https://crrev.com/8b9924f6effaee83b437e2b9b19d81dbfc1d4f61 Cr-Commit-Position: refs/heads/master@{#29218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
mvstanton
lgtm
5 years, 6 months ago (2015-06-22 17:25:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833003/1
5 years, 6 months ago (2015-06-22 17:25:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3612)
5 years, 6 months ago (2015-06-22 17:28:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833003/1
5 years, 6 months ago (2015-06-22 18:45:34 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3625)
5 years, 6 months ago (2015-06-22 18:53:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200833003/1
5 years, 6 months ago (2015-06-23 08:55:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 09:07:21 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 09:07:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b9924f6effaee83b437e2b9b19d81dbfc1d4f61
Cr-Commit-Position: refs/heads/master@{#29218}

Powered by Google App Engine
This is Rietveld 408576698