Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: LayoutTests/fast/mediastream/MediaDevices-enumerateDevices.html

Issue 1200783002: Address Peter's comments from past review (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/mediastream/MediaDevicesRequest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> 1 <!DOCTYPE HTML>
2 <title>mytest</title> 2 <title>mytest</title>
3 <script src="../../resources/testharness.js"></script> 3 <script src="../../resources/testharness.js"></script>
4 <script src="../../resources/testharnessreport.js"></script> 4 <script src="../../resources/testharnessreport.js"></script>
5 <script> 5 <script>
6 6
7 // Tests that the enumerateDevices() returns an array of at least 7 // Tests that the enumerateDevices() returns an array of at least
8 // one object with the correct fields 8 // one object with the correct fields
9 promise_test(function() { 9 promise_test(function() {
10 assert_idl_attribute(navigator, 'mediaDevices'); 10 assert_idl_attribute(navigator, 'mediaDevices');
11 assert_idl_attribute(navigator.mediaDevices, 'enumerateDevices'); 11 assert_idl_attribute(navigator.mediaDevices, 'enumerateDevices');
12 12
13 return navigator.mediaDevices.enumerateDevices().then(function(d) { 13 return navigator.mediaDevices.enumerateDevices().then(function(d) {
14 assert_true(d.length > 0); 14 assert_true(d.length > 0);
15 assert_idl_attribute(d[0], 'kind'); 15 assert_idl_attribute(d[0], 'kind');
16 assert_idl_attribute(d[0], 'deviceId'); 16 assert_idl_attribute(d[0], 'deviceId');
17 assert_idl_attribute(d[0], 'label'); 17 assert_idl_attribute(d[0], 'label');
18 assert_idl_attribute(d[0], 'groupId'); 18 assert_idl_attribute(d[0], 'groupId');
19 return Promise.resolve(); 19 return Promise.resolve();
20 }); 20 });
21 }, 'enumerateDevices()'); 21 }, 'enumerateDevices()');
22 22
23 </script> 23 </script>
OLDNEW
« no previous file with comments | « no previous file | Source/modules/mediastream/MediaDevicesRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698