Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1200783002: Address Peter's comments from past review (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Address Peter's comments from past review BUG=388648 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M LayoutTests/fast/mediastream/MediaDevices-enumerateDevices.html View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaDevicesRequest.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Guido Urdaneta
4 years, 10 months ago (2015-06-23 12:06:35 UTC) #2
Peter Beverloo
lgtm, thanks!
4 years, 10 months ago (2015-06-23 12:25:42 UTC) #3
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2015-06-23 20:23:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200783002/1
4 years, 10 months ago (2015-06-23 20:23:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60406)
4 years, 10 months ago (2015-06-23 21:35:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200783002/1
4 years, 10 months ago (2015-06-23 21:39:19 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 22:55:42 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197680

Powered by Google App Engine
This is Rietveld 408576698