Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 1200693002: Revert of [SP] Turn off slimming paint by default. (Closed)

Created:
5 years, 6 months ago by chrishtr
Modified:
5 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [SP] Turn off slimming paint by default. (patchset #2 id:20001 of https://codereview.chromium.org/1186623003/) Reason for revert: crbug.com/501015 made it hard to anaylyze the regressions in crbug.com/501251. the issue causing crbug.com/501015 has been reverted, so it's time to turn slimming paint back on. Original issue's description: > [SP] Turn off slimming paint by default. > > Partial revert of http://crrev.com/1169193003 while we explore performance > regressions. > > Leave the --disable-slimming-paint switch in existence, but restore > prior logic around switches. > > BUG=497950, 501251 > TBR=jochen > > Committed: https://crrev.com/3908f356c8af559adb6941adf4df77432b8275c2 > Cr-Commit-Position: refs/heads/master@{#335386} TBR=jochen@chromium.org,wkorman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497950, 501251 Committed: https://crrev.com/8db3efc9bb514d4e55a17fbd4d654c4ec4e72487 Cr-Commit-Position: refs/heads/master@{#335455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishtr
Created Revert of [SP] Turn off slimming paint by default.
5 years, 6 months ago (2015-06-21 18:47:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200693002/1
5 years, 6 months ago (2015-06-21 18:47:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-21 18:48:18 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8db3efc9bb514d4e55a17fbd4d654c4ec4e72487 Cr-Commit-Position: refs/heads/master@{#335455}
5 years, 6 months ago (2015-06-21 18:49:10 UTC) #6
wkorman
5 years, 6 months ago (2015-06-21 19:19:45 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698