Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 1200643004: Deflake fast/html/imports/import-expando-gc.html (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deflake fast/html/imports/import-expando-gc.html If a minor GC fails to identify the wrapper for the import document as reachable, it'll be collected. Make sure that this will not happen by way of a 'global' root. R=haraken BUG=503583 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/fast/html/imports/import-expando-gc.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look. I don't have a good grasp of minor GC V8GCController semantics, ...
5 years, 6 months ago (2015-06-23 12:55:02 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-23 12:57:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200643004/1
5 years, 6 months ago (2015-06-23 13:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200643004/1
5 years, 6 months ago (2015-06-23 14:12:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67877)
5 years, 6 months ago (2015-06-23 15:08:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200643004/1
5 years, 6 months ago (2015-06-23 15:12:18 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 15:15:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197655

Powered by Google App Engine
This is Rietveld 408576698