Issue 120063003: assert in setPixelRef that the pr matches the bitmap's config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 120063003: assert in setPixelRef that the pr matches the bitmap's config (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:
hal.canary

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

assert in setPixelRef that the pr matches the bitmap's config BUG= R=halcanary@google.com Committed: https://code.google.com/p/skia/source/detail?r=12880

Patch Set 2 : #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+25 lines, -0 lines	1 comment	Download
	M	tests/SerializationTest.cpp	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hal.canary

LGTM. https://codereview.chromium.org/120063003/diff/30001/src/core/SkBitmap.cpp File src/core/SkBitmap.cpp (right): https://codereview.chromium.org/120063003/diff/30001/src/core/SkBitmap.cpp#newcode418 src/core/SkBitmap.cpp:418: case kPremul_SkAlphaType: Under what circumstances will the alphatypes ...

6 years, 11 months ago (2014-01-02 22:36:01 UTC) #2

reed1

6 years, 11 months ago (2014-01-03 13:43:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r12880 (presubmit successful).

Expand Messages | Collapse Messages

Issue 120063003: assert in setPixelRef that the pr matches the bitmap's config (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages