Source/modules/encoding/TextDecoder.cpp - Issue 120063002: Improve modules' TypeError exception messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encoding/TextDecoder.cpp

Issue 120063002: Improve modules' TypeError exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/encoding/TextDecoder.cpp

diff --git a/Source/modules/encoding/TextDecoder.cpp b/Source/modules/encoding/TextDecoder.cpp

index e463c08f725499571fea8f9e70d3d0fb5051781c..06bf788e0f7aacde318748d8c796432d20bd9c67 100644

--- a/Source/modules/encoding/TextDecoder.cpp

+++ b/Source/modules/encoding/TextDecoder.cpp

@@ -44,7 +44,7 @@ PassRefPtr<TextDecoder> TextDecoder::create(const String& label, const Dictionar

WTF::TextEncoding encoding(encodingLabel);

if (!encoding.isValid()) {

- exceptionState.throwUninformativeAndGenericTypeError();

+ exceptionState.throwTypeError("The encoding label provided ('" + encodingLabel + "') is invalid.");

return 0;

}