Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/modules/encoding/TextDecoder.cpp

Issue 120063002: Improve modules' TypeError exception messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 26 matching lines...) Expand all
37 #include "wtf/text/TextEncodingRegistry.h" 37 #include "wtf/text/TextEncodingRegistry.h"
38 38
39 namespace WebCore { 39 namespace WebCore {
40 40
41 PassRefPtr<TextDecoder> TextDecoder::create(const String& label, const Dictionar y& options, ExceptionState& exceptionState) 41 PassRefPtr<TextDecoder> TextDecoder::create(const String& label, const Dictionar y& options, ExceptionState& exceptionState)
42 { 42 {
43 const String& encodingLabel = label.isNull() ? String("utf-8") : label; 43 const String& encodingLabel = label.isNull() ? String("utf-8") : label;
44 44
45 WTF::TextEncoding encoding(encodingLabel); 45 WTF::TextEncoding encoding(encodingLabel);
46 if (!encoding.isValid()) { 46 if (!encoding.isValid()) {
47 exceptionState.throwUninformativeAndGenericTypeError(); 47 exceptionState.throwTypeError("The encoding label provided ('" + encodin gLabel + "') is invalid.");
48 return 0; 48 return 0;
49 } 49 }
50 50
51 bool fatal = false; 51 bool fatal = false;
52 options.get("fatal", fatal); 52 options.get("fatal", fatal);
53 53
54 return adoptRef(new TextDecoder(encoding.name(), fatal)); 54 return adoptRef(new TextDecoder(encoding.name(), fatal));
55 } 55 }
56 56
57 57
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 s.remove(0); 105 s.remove(0);
106 } 106 }
107 107
108 if (flush) 108 if (flush)
109 m_bomSeen = false; 109 m_bomSeen = false;
110 110
111 return s; 111 return s;
112 } 112 }
113 113
114 } // namespace WebCore 114 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698