Improve modules' TypeError exception messages.

Improve modules' TypeError exception messages.

BUG=270033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164591

[Mike West, 2013-12-20 16:17:39]

You're not OOO. I can see you _right now_.

-mike

[jsbell, 2013-12-20 17:47:49]

On behalf of Source/modules/encoding and Source/modules/indexeddb, LGTM

Do we really not have tests that exercise those IndexedDB exceptions?

https://codereview.chromium.org/120063002/diff/1/Source/modules/encoding/Text...
File Source/modules/encoding/TextEncoder.cpp (right):

https://codereview.chromium.org/120063002/diff/1/Source/modules/encoding/Text...
Source/modules/encoding/TextEncoder.cpp:54: exceptionState.throwTypeError("The
encoding label provided ('" + encodingLabel + "') is not one of 'UTF-8',
'UTF-16LE', or 'UTF-16BE'.");
Nit: Lots of labels aliases for these are accepted, and these aren't the
preferred names per the spec.

Suggest: 'utf-8', 'utf-16', or 'utf-16be'

[jsbell, 2013-12-20 17:51:07]

https://codereview.chromium.org/120063002/diff/1/Source/modules/encoding/Text...
File Source/modules/encoding/TextEncoder.cpp (right):

https://codereview.chromium.org/120063002/diff/1/Source/modules/encoding/Text...
Source/modules/encoding/TextEncoder.cpp:54: exceptionState.throwTypeError("The
encoding label provided ('" + encodingLabel + "') is not one of 'UTF-8',
'UTF-16LE', or 'UTF-16BE'.");
On 2013/12/20 17:47:50, jsbell wrote:
> Nit: Lots of labels aliases for these are accepted, and these aren't the
> preferred names per the spec.
> 
> Suggest: 'utf-8', 'utf-16', or 'utf-16be'
> 

And maybe "encoding provided" instead of "encoding label provided"; the previous
isValid() test rules out invalid *labels*; at this point the label is valid,
it's the encoding that's forbidden.

[Mike West, 2014-01-07 11:14:38]

Done both (and rebaselined the indexeddb tests that do, in fact, exist), thank
you!

[Mike West, 2014-01-07 12:55:26]

Jochen, mind taking a look at the rest?

[jochen (gone - plz use gerrit), 2014-01-07 13:29:23]

not a single test for the promise thing? :-/

lgtm on your changes

[commit-bot: I haz the power, 2014-01-07 13:30:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/120063002/120001

[commit-bot: I haz the power, 2014-01-07 13:30:59]

Failed to apply patch for
LayoutTests/storage/indexeddb/cursor-advance-expected.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/storage/indexeddb/cursor-advance-expected.txt
  Hunk #1 FAILED at 178.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/storage/indexeddb/cursor-advance-expected.txt.rej

Patch:       LayoutTests/storage/indexeddb/cursor-advance-expected.txt
Index: LayoutTests/storage/indexeddb/cursor-advance-expected.txt
diff --git a/LayoutTests/storage/indexeddb/cursor-advance-expected.txt
b/LayoutTests/storage/indexeddb/cursor-advance-expected.txt
index
6bb8f64f575b388c6bdcea9c7ce75bcfe96cd6d1..b7471cc7e477e7769aa262eefb609e47ddfe6ecc
100644
--- a/LayoutTests/storage/indexeddb/cursor-advance-expected.txt
+++ b/LayoutTests/storage/indexeddb/cursor-advance-expected.txt
@@ -178,7 +178,7 @@ request = objectStore.openCursor()
 advanceBadly():
 Expecting TypeError exception from cursor.advance(0)
 PASS Exception was thrown.
-PASS cursor.advance(0) threw TypeError: Type error
+PASS cursor.advance(0) threw TypeError: Failed to execute 'advance' on
'IDBCursor': The count provided is 0.
 Expecting TypeError exception from cursor.advance(-1)
 PASS Exception was thrown.
 PASS cursor.advance(-1) threw TypeError: Type error

[commit-bot: I haz the power, 2014-01-07 13:57:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/120063002/180001

[commit-bot: I haz the power, 2014-01-07 15:26:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/120063002/180001

[commit-bot: I haz the power, 2014-01-07 16:11:05]

Change committed as 164591