Integrate PasswordStoreProxyMac instead of PasswordStoreMac.

Integrate PasswordStoreProxyMac instead of PasswordStoreMac.

For now PasswordStoreProxyMac is just a wrapper around PasswordStoreMac.
The goal is to remove the Keychain integration on Mac. Design doc: https://docs.google.com/a/google.com/document/d/1A8ZG16bLuUH1u21K0GoABKz_wpz1kchXMnMlpmq_ecA/edit?usp=sharing

BUG=466638
Committed: https://crrev.com/d76cd87932e59af30da4ad138722ed4c8b54fe3c
Cr-Commit-Position: refs/heads/master@{#336130}

[vasilii, 2015-06-23 18:59:16]

vasilii@chromium.org changed reviewers:
+ gcasto@chromium.org

[vasilii, 2015-06-23 19:05:58]

Hi Garrett,

please review the CL.

[vasilii, 2015-06-24 18:47:01]

On 2015/06/23 19:05:58, vasilii wrote:
> Hi Garrett,
> 
> please review the CL.

The branch point was shifted. Anyway, please review :-)

[Garrett Casto, 2015-06-24 23:39:10]

LGTM

Very minor comments. The refactoring of more code into PasswordStore is nice.

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/password_store_mac.h (right):

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:25: // TODO(vasilii):
deprecate. The class should be used by PasswordStoreProxyMac
Nit: deprecate -> Deprecate this class.

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:40: // Initializes
|thread_|.
Stale comment.

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:44: // Stops |thread_|.
Stale comment.

[vasilii, 2015-06-25 08:23:23]

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
File chrome/browser/password_manager/password_store_mac.h (right):

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:25: // TODO(vasilii):
deprecate. The class should be used by PasswordStoreProxyMac
On 2015/06/24 23:39:09, Garrett Casto wrote:
> Nit: deprecate -> Deprecate this class.

Done.

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:40: // Initializes
|thread_|.
On 2015/06/24 23:39:10, Garrett Casto wrote:
> Stale comment.

Done.

https://codereview.chromium.org/1200603003/diff/20001/chrome/browser/password...
chrome/browser/password_manager/password_store_mac.h:44: // Stops |thread_|.
On 2015/06/24 23:39:09, Garrett Casto wrote:
> Stale comment.

Done.

[vasilii, 2015-06-25 08:23:31]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2015-06-25 08:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from gcasto@chromium.org
Link to the patchset: https://codereview.chromium.org/1200603003/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2015-06-25 09:02:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200603003/40001

[commit-bot: I haz the power, 2015-06-25 11:15:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 11:15:59]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2015-06-25 11:28:08]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2015-06-25 11:28:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1200603003/40001

[commit-bot: I haz the power, 2015-06-25 12:00:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-25 12:01:33]

Patchset 3 (id:??) landed as
https://crrev.com/d76cd87932e59af30da4ad138722ed4c8b54fe3c
Cr-Commit-Position: refs/heads/master@{#336130}