Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1200583002: Revert "Android: Store language .pak files in res/raw rather than assets" (Closed)

Created:
5 years, 6 months ago by qinmin
Modified:
5 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, android-webview-reviews_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, gunsch+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Android: Store language .pak files in res/raw rather than assets" This reverts commit f30e04470453ccd7e6a9abf586185b991d174902. This change breaks android TOT bot TBR=yfriedman@chromium.org,torne@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,jhawkins@chromium.org,gunsch@chromium.org,newt@chromium.org,agrieve@chromium.org BUG=371610 Committed: https://crrev.com/bd0057ca4ca5990173e099f5cdd5219c6ed72fd5 Cr-Commit-Position: refs/heads/master@{#335432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -352 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellApplication.java View 1 chunk +2 lines, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 9 chunks +123 lines, -92 lines 0 comments Download
D build/android/gyp/locale_pak_resources.py View 1 chunk +0 lines, -97 lines 0 comments Download
D build/android/locale_pak_resources.gypi View 1 chunk +0 lines, -52 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/android/BUILD.gn View 4 chunks +9 lines, -20 lines 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 2 chunks +44 lines, -2 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1200583002/1
5 years, 6 months ago (2015-06-20 04:15:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-20 05:25:53 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 05:26:44 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bd0057ca4ca5990173e099f5cdd5219c6ed72fd5
Cr-Commit-Position: refs/heads/master@{#335432}

Powered by Google App Engine
This is Rietveld 408576698